Remove VMR content from dotnet/sdk #48695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Don't the pipelines point to |
premun
approved these changes
Apr 25, 2025
Member
Author
Yes you are correct. I only noticed that later. |
Member
|
@ViktorHofer does this mean we can't apply VMR patches in dotnet/sdk, and send PRs directly to dotnet/dotnet? |
Member
Author
|
Yes. We don't yet encourage contributors to open PRs against dotnet/dotnet as we still fine tune the experience. You are a well known and trusted contributor so if the change is small and unblocks a scenario (fix vs feature) I'm happy to take it already now. After P5 (about 3-4 weeks from now) we then open the gates for everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO MERGE until we added the pipeline YMLs to the VMR Orchestrator
Changes are segregated into commits